Discussion:
GRAILS-8494
Sandeep Samdaria
2014-03-11 15:18:25 UTC
Permalink
Hi,
I have been developing grails application for almost a year. For an app, I
had to disable certain options in the select tag.
After doing a google search, I stumbled upon
GRAILS-8494<http://jira.grails.org/browse/GRAILS-8494> and
decided to implement that in my project.As of now, my implementation takes
only a closure for "optionDisabled" (I feel the ticket can be updated to
use extra options "keysDisabled" for select tag)

I have followed the Contribute <http://grails.org/Contribute> section and
have setup the grails-core project on STS. I have attached the patch in the
JIRA.I am a little lost on how to contribute back to the community.If you
guys can please guide me or send a pointer to documents link,I will be able
to follow the process and contribute back.

Thanks,
Sandeep.
Graeme Rocher
2014-03-12 08:20:12 UTC
Permalink
Please attach the patch to the JIRA issue or even better send a github
pull request

Thanks

On Tue, Mar 11, 2014 at 4:18 PM, Sandeep Samdaria
Post by Sandeep Samdaria
Hi,
I have been developing grails application for almost a year. For an app, I
had to disable certain options in the select tag.
After doing a google search, I stumbled upon GRAILS-8494 and decided to
implement that in my project.As of now, my implementation takes only a
closure for "optionDisabled" (I feel the ticket can be updated to use extra
options "keysDisabled" for select tag)
I have followed the Contribute section and have setup the grails-core
project on STS. I have attached the patch in the JIRA.I am a little lost on
how to contribute back to the community.If you guys can please guide me or
send a pointer to documents link,I will be able to follow the process and
contribute back.
Thanks,
Sandeep.
---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email
--
Graeme Rocher
Grails Project Lead
SpringSource

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email
Sandeep Samdaria
2014-03-12 10:03:11 UTC
Permalink
I have already attached the patch on jira and added a comment on JIRA
describing what the fix is. I will send a github pull request also.
Please excuse my ignorance, in addition to sending the pull request, should
I do anything else extra?

Thanks,
Sandeep.
Post by Graeme Rocher
Please attach the patch to the JIRA issue or even better send a github
pull request
Thanks
On Tue, Mar 11, 2014 at 4:18 PM, Sandeep Samdaria
Post by Sandeep Samdaria
Hi,
I have been developing grails application for almost a year. For an app,
I
Post by Sandeep Samdaria
had to disable certain options in the select tag.
After doing a google search, I stumbled upon GRAILS-8494 and decided to
implement that in my project.As of now, my implementation takes only a
closure for "optionDisabled" (I feel the ticket can be updated to use
extra
Post by Sandeep Samdaria
options "keysDisabled" for select tag)
I have followed the Contribute section and have setup the grails-core
project on STS. I have attached the patch in the JIRA.I am a little lost
on
Post by Sandeep Samdaria
how to contribute back to the community.If you guys can please guide me
or
Post by Sandeep Samdaria
send a pointer to documents link,I will be able to follow the process and
contribute back.
Thanks,
Sandeep.
---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email
--
Graeme Rocher
Grails Project Lead
SpringSource
---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email
Graeme Rocher
2014-03-12 10:39:23 UTC
Permalink
Nope, thanks for the contribution

On Wed, Mar 12, 2014 at 11:03 AM, Sandeep Samdaria
Post by Sandeep Samdaria
I have already attached the patch on jira and added a comment on JIRA
describing what the fix is. I will send a github pull request also.
Please excuse my ignorance, in addition to sending the pull request, should
I do anything else extra?
Thanks,
Sandeep.
Post by Graeme Rocher
Please attach the patch to the JIRA issue or even better send a github
pull request
Thanks
On Tue, Mar 11, 2014 at 4:18 PM, Sandeep Samdaria
Post by Sandeep Samdaria
Hi,
I have been developing grails application for almost a year. For an app, I
had to disable certain options in the select tag.
After doing a google search, I stumbled upon GRAILS-8494 and decided to
implement that in my project.As of now, my implementation takes only a
closure for "optionDisabled" (I feel the ticket can be updated to use extra
options "keysDisabled" for select tag)
I have followed the Contribute section and have setup the grails-core
project on STS. I have attached the patch in the JIRA.I am a little lost on
how to contribute back to the community.If you guys can please guide me or
send a pointer to documents link,I will be able to follow the process and
contribute back.
Thanks,
Sandeep.
---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email
--
Graeme Rocher
Grails Project Lead
SpringSource
---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email
--
Graeme Rocher
Grails Project Lead
SpringSource

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email
Sandeep Samdaria
2014-03-13 16:36:14 UTC
Permalink
Hi,
I have sent a pull request https://github.com/grails/grails-core/pull/471.
Please take a look and let me know your comments.

Thanks,
Sandeep.
Post by Graeme Rocher
Nope, thanks for the contribution
On Wed, Mar 12, 2014 at 11:03 AM, Sandeep Samdaria
Post by Sandeep Samdaria
I have already attached the patch on jira and added a comment on JIRA
describing what the fix is. I will send a github pull request also.
Please excuse my ignorance, in addition to sending the pull request,
should
Post by Sandeep Samdaria
I do anything else extra?
Thanks,
Sandeep.
Post by Graeme Rocher
Please attach the patch to the JIRA issue or even better send a github
pull request
Thanks
On Tue, Mar 11, 2014 at 4:18 PM, Sandeep Samdaria
Post by Sandeep Samdaria
Hi,
I have been developing grails application for almost a year. For an
app,
Post by Sandeep Samdaria
Post by Graeme Rocher
Post by Sandeep Samdaria
I
had to disable certain options in the select tag.
After doing a google search, I stumbled upon GRAILS-8494 and decided
to
Post by Sandeep Samdaria
Post by Graeme Rocher
Post by Sandeep Samdaria
implement that in my project.As of now, my implementation takes only a
closure for "optionDisabled" (I feel the ticket can be updated to use extra
options "keysDisabled" for select tag)
I have followed the Contribute section and have setup the grails-core
project on STS. I have attached the patch in the JIRA.I am a little
lost
Post by Sandeep Samdaria
Post by Graeme Rocher
Post by Sandeep Samdaria
on
how to contribute back to the community.If you guys can please guide
me
Post by Sandeep Samdaria
Post by Graeme Rocher
Post by Sandeep Samdaria
or
send a pointer to documents link,I will be able to follow the process and
contribute back.
Thanks,
Sandeep.
---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email
--
Graeme Rocher
Grails Project Lead
SpringSource
---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email
--
Graeme Rocher
Grails Project Lead
SpringSource
---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email
Loading...